fix: flaky test test_transformers_image_embedder_other

[kevinzwang]

Changes Made

This test keeps failing in CI. Adding a retry here so that it succeeds.

Related Issues

Checklist

• Documented in API Docs (if applicable)
• Documented in User Guide (if applicable)
• If adding a new documentation page, doc is added to docs/mkdocs.yml navigation
• Documentation builds and is formatted properly (tag @/ccmao1130 for docs review)

[greptile-apps]

Greptile Summary

This PR fixes a flaky test in the transformers image embedding functionality by adding retry logic to handle transient failures during Hugging Face model instantiation. The change specifically targets the test_transformers_image_embedder_other test in tests/ai/test_transformers.py, which has been experiencing intermittent failures in CI environments.

The implementation adds a retry mechanism that attempts model instantiation up to 5 times with 5-second delays between attempts. The retry logic only catches OSError exceptions (which are typical for network/IO failures when downloading models) and re-raises the original exception if all retries are exhausted. A time import was added to support the sleep functionality between retry attempts.

This approach addresses the external dependency flakiness without modifying the core AI functionality. The test structure remains the same, with the retry logic wrapping only the problematic descriptor.instantiate() call. This is a pragmatic solution for dealing with transient external service issues that are outside the control of the Daft codebase, specifically related to Hugging Face's service reliability during model downloads.

Confidence score: 4/5

• This PR is safe to merge with minimal risk as it only adds defensive retry logic to a flaky test
• Score reflects a well-implemented retry mechanism with appropriate exception handling and reasonable retry parameters
• No files require special attention as this is a straightforward test stability improvement

Context used:

Rule - Import statements should be placed at the top of the file rather than inline within functions or methods. (link)

_{1 file reviewed, no comments}

_{Edit Code Review Bot Settings | Greptile}

[desmondcheongzx]

I do wonder if we should slap the retries onto the instantiate itself instead of the test, but something for another time perhaps

[kevinzwang]

@desmondcheongzx do you know why most of the tests are not running? I'm not super familiar with the skipcheck job which I assume is telling the other tests that it should be skipped.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.88%. Comparing base (ef36735) to head (489f014).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5130   +/-   ##
=======================================
  Coverage   71.87%   71.88%           
=======================================
  Files         953      953           
  Lines      130522   130524    +2     
=======================================
+ Hits        93816    93821    +5     
+ Misses      36706    36703    -3     

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.