Skip to content

Conversation

ykdojo
Copy link
Contributor

@ykdojo ykdojo commented Sep 3, 2025

Changes Made

On the overview page, when the typewriter animation finished rendering the text, it flickered, which didn't feel good on your eye. Fixed by removing the abrupt fade-in effect and replacing with a subtle cursor fade that falls gently.

Before

flicker.mov

After

fall.mov

Checklist

  • Documentation builds and is formatted properly

Internal

Closes https://linear.app/eventual/issue/EVE-839/on-the-overview-page-when-the-animation-finishes-rendering-the-text-it

Remove fade-in CSS class and animation that was causing visual flicker
when typewriter effect finished. Text now remains stable after typing
completes without unnecessary fade transition.
Enhance cursor fade with gentle 10-degree clockwise rotation from
bottom-right corner, creating a natural "tipping over" motion as
the cursor disappears.
@github-actions github-actions bot added the docs label Sep 3, 2025
Move daft-caret keyframe back to its original position after cursor class
definition, keeping new cursor-fade code separate.
Remove unnecessary color declaration since cursor inherits color from parent.
@ykdojo ykdojo requested a review from ccmao1130 September 3, 2025 16:09
@ykdojo ykdojo marked this pull request as ready for review September 3, 2025 16:09
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR fixes a visual flickering issue in the typewriter animation on the documentation overview page (docs/index.md). The change improves the user experience by replacing an abrupt fade-in effect with a more elegant cursor fade animation.

The modification involves removing the old .fade-in CSS class and its associated daft-enter keyframes that caused jarring opacity and translateY transitions. In its place, a new .cursor-fade class is introduced with a subtle animation that rotates the cursor 10 degrees while fading its opacity over 400ms. The JavaScript logic is also updated to allow the cursor to continue blinking naturally for 2.2 seconds before applying the gentle fade effect.

This change fits well within the Daft documentation ecosystem, enhancing the visual polish of the main landing page without affecting any core functionality. The animation improvements align with providing a professional, high-quality documentation experience for users discovering the data processing framework.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only affects CSS animations and JavaScript timing on a documentation page
  • Score reflects that this is purely a visual enhancement with no impact on core functionality or data processing capabilities
  • No files require special attention as the changes are isolated to styling and animation improvements

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@desmondcheongzx desmondcheongzx merged commit bbd8cc1 into main Sep 3, 2025
28 of 29 checks passed
@desmondcheongzx desmondcheongzx deleted the fix/overview-page-animation-flicker branch September 3, 2025 17:07
venkateshdb pushed a commit to venkateshdb/Daft that referenced this pull request Sep 6, 2025
…Inc#5118)

## Changes Made

On the overview page, when the typewriter animation finished rendering
the text, it flickered, which didn't feel good on your eye. Fixed by
removing the abrupt fade-in effect and replacing with a subtle cursor
fade that falls gently.

## Before


https://github.com/user-attachments/assets/00dc1aff-c70d-4e07-8490-7f9b13698ecf

## After


https://github.com/user-attachments/assets/c4efc583-7e14-438e-a38b-e22d37ff0a72

## Checklist

- [x] Documentation builds and is formatted properly

## Internal

Closes
https://linear.app/eventual/issue/EVE-839/on-the-overview-page-when-the-animation-finishes-rendering-the-text-it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants