-
Notifications
You must be signed in to change notification settings - Fork 297
docs: fix flickering typewriter animation on overview page #5118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove fade-in CSS class and animation that was causing visual flicker when typewriter effect finished. Text now remains stable after typing completes without unnecessary fade transition.
Enhance cursor fade with gentle 10-degree clockwise rotation from bottom-right corner, creating a natural "tipping over" motion as the cursor disappears.
Move daft-caret keyframe back to its original position after cursor class definition, keeping new cursor-fade code separate.
Remove unnecessary color declaration since cursor inherits color from parent.
This reverts commit 3ef4e6e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR fixes a visual flickering issue in the typewriter animation on the documentation overview page (docs/index.md
). The change improves the user experience by replacing an abrupt fade-in effect with a more elegant cursor fade animation.
The modification involves removing the old .fade-in
CSS class and its associated daft-enter
keyframes that caused jarring opacity and translateY transitions. In its place, a new .cursor-fade
class is introduced with a subtle animation that rotates the cursor 10 degrees while fading its opacity over 400ms. The JavaScript logic is also updated to allow the cursor to continue blinking naturally for 2.2 seconds before applying the gentle fade effect.
This change fits well within the Daft documentation ecosystem, enhancing the visual polish of the main landing page without affecting any core functionality. The animation improvements align with providing a professional, high-quality documentation experience for users discovering the data processing framework.
Confidence score: 5/5
- This PR is safe to merge with minimal risk as it only affects CSS animations and JavaScript timing on a documentation page
- Score reflects that this is purely a visual enhancement with no impact on core functionality or data processing capabilities
- No files require special attention as the changes are isolated to styling and animation improvements
1 file reviewed, no comments
…Inc#5118) ## Changes Made On the overview page, when the typewriter animation finished rendering the text, it flickered, which didn't feel good on your eye. Fixed by removing the abrupt fade-in effect and replacing with a subtle cursor fade that falls gently. ## Before https://github.com/user-attachments/assets/00dc1aff-c70d-4e07-8490-7f9b13698ecf ## After https://github.com/user-attachments/assets/c4efc583-7e14-438e-a38b-e22d37ff0a72 ## Checklist - [x] Documentation builds and is formatted properly ## Internal Closes https://linear.app/eventual/issue/EVE-839/on-the-overview-page-when-the-animation-finishes-rendering-the-text-it
Changes Made
On the overview page, when the typewriter animation finished rendering the text, it flickered, which didn't feel good on your eye. Fixed by removing the abrupt fade-in effect and replacing with a subtle cursor fade that falls gently.
Before
flicker.mov
After
fall.mov
Checklist
Internal
Closes https://linear.app/eventual/issue/EVE-839/on-the-overview-page-when-the-animation-finishes-rendering-the-text-it