-
Notifications
You must be signed in to change notification settings - Fork 295
fix: nightly property test #5076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
704063d
to
9edc654
Compare
@greptileai one more time |
93e3dd2
to
fd09202
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5076 +/- ##
==========================================
+ Coverage 75.27% 76.45% +1.17%
==========================================
Files 949 949
Lines 132520 130350 -2170
==========================================
- Hits 99761 99665 -96
+ Misses 32759 30685 -2074 🚀 New features to boost your workflow:
|
06164a3
to
a20bf05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make sure to run it manually and check if it works before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This review covers only the changes made since the last review (commit ff23a54), not the entire PR.
The most recent changes address the previous feedback about removing problematic source activate
commands from the GitHub Actions workflow. The developer has cleaned up two critical sections where virtual environment activation was being attempted in ways that don't work properly in GitHub Actions:
-
Rust library build step: Removed the
source activate
command that was preceding thematurin develop --uv --release
command. This activation command would not persist between shell invocations in GitHub Actions and could cause the build to fail. -
Test execution step: Removed the
source activate
command that was preceding the pytest execution. Since the PATH was already modified to include the virtual environment's bin directory, this activation was redundant and potentially problematic.
These changes follow GitHub Actions best practices where environment modifications (like the earlier PATH update with echo "$GITHUB_WORKSPACE/.venv/bin" >> $GITHUB_PATH
) are the preferred way to make tools available across workflow steps, rather than using shell-specific activation commands that don't persist.
Confidence score: 4/5
- This PR is now safe to merge with minimal risk after addressing the activation command issues
- Score reflects the removal of problematic shell commands that could cause CI failures
- No files require special attention as the changes are straightforward CI workflow improvements
1 file reviewed, no comments
Fixes the nightly property tests by installing `uv`. Uses the astral-sh action for improved caching.
Fixes the nightly property tests by installing `uv`. Uses the astral-sh action for improved caching.
Fixes the nightly property tests by installing
uv
. Uses the astral-sh action for improved caching.