-
Notifications
You must be signed in to change notification settings - Fork 295
fix: Fix venv command for windows build #5073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR enables Windows builds in the Daft project's CI/CD pipeline by fixing platform-specific virtual environment handling. The changes span two GitHub Actions workflow files to properly support Windows wheel building alongside existing Ubuntu builds.
The primary fix is in build-wheel.yml
where the virtual environment activation logic is updated to handle Windows' different directory structure. On Windows, Python virtual environments store activation scripts in Scripts/
directory rather than bin/
, requiring platform-specific path handling. The code now conditionally sets the correct PATH and uses the appropriate activation command based on the operating system.
The publish-dev-s3.yml
workflow is extended to include Windows in its build matrix, adding windows
to the OS options while excluding the unsupported windows-aarch64
combination. This enables Windows wheel distribution to S3 for development builds.
These changes integrate with Daft's existing build infrastructure by leveraging the reusable build-wheel.yml
workflow that's called from multiple contexts. The fix ensures that the same build process can work across both Unix-like systems and Windows without breaking existing functionality.
PR Description Notes:
- The PR description is incomplete with empty placeholder sections and no actual description of changes
- Missing related issues information
- All checklist items are unchecked
Confidence score: 4/5
- This PR addresses a clear platform compatibility issue with a straightforward solution that should resolve Windows build failures
- Score reflects well-targeted changes that fix a specific cross-platform issue without introducing complexity or breaking existing functionality
- Pay close attention to the virtual environment path handling logic in build-wheel.yml to ensure Windows/Unix compatibility is correctly implemented
2 files reviewed, no comments
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5073 +/- ##
==========================================
+ Coverage 75.27% 76.00% +0.73%
==========================================
Files 949 949
Lines 132520 130350 -2170
==========================================
- Hits 99761 99079 -682
+ Misses 32759 31271 -1488 🚀 New features to boost your workflow:
|
## Changes Made <!-- Describe what changes were made and why. Include implementation details if necessary. --> ## Related Issues <!-- Link to related GitHub issues, e.g., "Closes Eventual-Inc#123" --> ## Checklist - [ ] Documented in API Docs (if applicable) - [ ] Documented in User Guide (if applicable) - [ ] If adding a new documentation page, doc is added to `docs/mkdocs.yml` navigation - [ ] Documentation builds and is formatted properly (tag @/ccmao1130 for docs review)
## Changes Made <!-- Describe what changes were made and why. Include implementation details if necessary. --> ## Related Issues <!-- Link to related GitHub issues, e.g., "Closes Eventual-Inc#123" --> ## Checklist - [ ] Documented in API Docs (if applicable) - [ ] Documented in User Guide (if applicable) - [ ] If adding a new documentation page, doc is added to `docs/mkdocs.yml` navigation - [ ] Documentation builds and is formatted properly (tag @/ccmao1130 for docs review)
Changes Made
Related Issues
Checklist
docs/mkdocs.yml
navigation