Skip to content

Conversation

colin-ho
Copy link
Contributor

Changes Made

Related Issues

Checklist

  • Documented in API Docs (if applicable)
  • Documented in User Guide (if applicable)
  • If adding a new documentation page, doc is added to docs/mkdocs.yml navigation
  • Documentation builds and is formatted properly (tag @/ccmao1130 for docs review)

@github-actions github-actions bot added the fix label Aug 28, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR enables Windows builds in the Daft project's CI/CD pipeline by fixing platform-specific virtual environment handling. The changes span two GitHub Actions workflow files to properly support Windows wheel building alongside existing Ubuntu builds.

The primary fix is in build-wheel.yml where the virtual environment activation logic is updated to handle Windows' different directory structure. On Windows, Python virtual environments store activation scripts in Scripts/ directory rather than bin/, requiring platform-specific path handling. The code now conditionally sets the correct PATH and uses the appropriate activation command based on the operating system.

The publish-dev-s3.yml workflow is extended to include Windows in its build matrix, adding windows to the OS options while excluding the unsupported windows-aarch64 combination. This enables Windows wheel distribution to S3 for development builds.

These changes integrate with Daft's existing build infrastructure by leveraging the reusable build-wheel.yml workflow that's called from multiple contexts. The fix ensures that the same build process can work across both Unix-like systems and Windows without breaking existing functionality.

PR Description Notes:

  • The PR description is incomplete with empty placeholder sections and no actual description of changes
  • Missing related issues information
  • All checklist items are unchecked

Confidence score: 4/5

  • This PR addresses a clear platform compatibility issue with a straightforward solution that should resolve Windows build failures
  • Score reflects well-targeted changes that fix a specific cross-platform issue without introducing complexity or breaking existing functionality
  • Pay close attention to the virtual environment path handling logic in build-wheel.yml to ensure Windows/Unix compatibility is correctly implemented

2 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

@colin-ho colin-ho enabled auto-merge (squash) August 28, 2025 14:16
@colin-ho colin-ho merged commit 248b7e8 into main Aug 28, 2025
54 checks passed
@colin-ho colin-ho deleted the colin/fix-windows-build branch August 28, 2025 14:59
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.00%. Comparing base (ae638e5) to head (650224e).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5073      +/-   ##
==========================================
+ Coverage   75.27%   76.00%   +0.73%     
==========================================
  Files         949      949              
  Lines      132520   130350    -2170     
==========================================
- Hits        99761    99079     -682     
+ Misses      32759    31271    -1488     

see 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Jay-ju pushed a commit to Jay-ju/Daft that referenced this pull request Sep 1, 2025
## Changes Made

<!-- Describe what changes were made and why. Include implementation
details if necessary. -->

## Related Issues

<!-- Link to related GitHub issues, e.g., "Closes Eventual-Inc#123" -->

## Checklist

- [ ] Documented in API Docs (if applicable)
- [ ] Documented in User Guide (if applicable)
- [ ] If adding a new documentation page, doc is added to
`docs/mkdocs.yml` navigation
- [ ] Documentation builds and is formatted properly (tag @/ccmao1130
for docs review)
venkateshdb pushed a commit to venkateshdb/Daft that referenced this pull request Sep 6, 2025
## Changes Made

<!-- Describe what changes were made and why. Include implementation
details if necessary. -->

## Related Issues

<!-- Link to related GitHub issues, e.g., "Closes Eventual-Inc#123" -->

## Checklist

- [ ] Documented in API Docs (if applicable)
- [ ] Documented in User Guide (if applicable)
- [ ] If adding a new documentation page, doc is added to
`docs/mkdocs.yml` navigation
- [ ] Documentation builds and is formatted properly (tag @/ccmao1130
for docs review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant