Skip to content

Conversation

desmondcheongzx
Copy link
Collaborator

Changes Made

Trivial non-code changes are clogging our CI. This needs to stop.

@github-actions github-actions bot added the ci label Aug 18, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR modifies the .github/workflows/pr-test-suite.yml GitHub Actions workflow to add paths-ignore filters that prevent the PR test suite from running when only non-code files are changed. The change addresses CI performance issues where trivial updates to documentation, configuration files, benchmarking scripts, and other non-functional files were unnecessarily triggering the full test suite.

The filters are applied to both push and pull_request triggers and exclude a comprehensive list of file patterns including documentation files (*.md, docs/**), configuration files (*.toml, *.yml, *.yaml), benchmarking scripts (benchmarking/**), tutorials (tutorials/**), and various other non-code assets. This optimization allows GitHub Actions to skip workflow execution entirely when only these excluded file types are modified, rather than running the full test suite and consuming CI resources unnecessarily.

This type of workflow optimization is a common CI/CD best practice that helps reduce build queue times and resource consumption while maintaining test coverage for actual code changes. The change integrates well with the existing workflow structure by adding the paths-ignore configuration without modifying any other workflow logic.

Confidence score: 3/5

  • This PR contains a critical typo that will cause the workflow to potentially run when it shouldn't, reducing the effectiveness of the optimization
  • Score lowered due to the filename typo in .git-glame-ignore-revs which should be .git-blame-ignore-revs
  • Pay close attention to the paths-ignore list in .github/workflows/pr-test-suite.yml to verify the typo and ensure all intended file patterns are correctly specified

1 file reviewed, 2 comments

Edit Code Review Bot Settings | Greptile

desmondcheongzx and others added 2 commits August 18, 2025 13:43
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@desmondcheongzx desmondcheongzx enabled auto-merge (squash) August 18, 2025 21:05
@desmondcheongzx desmondcheongzx merged commit 8416102 into main Aug 18, 2025
98 of 100 checks passed
@desmondcheongzx desmondcheongzx deleted the desmond/relax-ci branch August 18, 2025 23:16
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (4dd0d98) to head (9cf50c8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4992      +/-   ##
==========================================
+ Coverage   75.33%   76.60%   +1.26%     
==========================================
  Files         929      929              
  Lines      130509   128392    -2117     
==========================================
+ Hits        98319    98354      +35     
+ Misses      32190    30038    -2152     

see 53 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

desmondcheongzx added a commit that referenced this pull request Aug 21, 2025
desmondcheongzx added a commit that referenced this pull request Aug 28, 2025
## Changes Made

#4992 had to be reverted because of required checks. We do it for real
this time.
Jay-ju pushed a commit to Jay-ju/Daft that referenced this pull request Sep 1, 2025
## Changes Made

Eventual-Inc#4992 had to be reverted because of required checks. We do it for real
this time.
venkateshdb pushed a commit to venkateshdb/Daft that referenced this pull request Sep 6, 2025
## Changes Made

Eventual-Inc#4992 had to be reverted because of required checks. We do it for real
this time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant