-
Notifications
You must be signed in to change notification settings - Fork 294
ci: Don't run pr test suite on non-code changes #4992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR modifies the .github/workflows/pr-test-suite.yml
GitHub Actions workflow to add paths-ignore
filters that prevent the PR test suite from running when only non-code files are changed. The change addresses CI performance issues where trivial updates to documentation, configuration files, benchmarking scripts, and other non-functional files were unnecessarily triggering the full test suite.
The filters are applied to both push
and pull_request
triggers and exclude a comprehensive list of file patterns including documentation files (*.md
, docs/**
), configuration files (*.toml
, *.yml
, *.yaml
), benchmarking scripts (benchmarking/**
), tutorials (tutorials/**
), and various other non-code assets. This optimization allows GitHub Actions to skip workflow execution entirely when only these excluded file types are modified, rather than running the full test suite and consuming CI resources unnecessarily.
This type of workflow optimization is a common CI/CD best practice that helps reduce build queue times and resource consumption while maintaining test coverage for actual code changes. The change integrates well with the existing workflow structure by adding the paths-ignore
configuration without modifying any other workflow logic.
Confidence score: 3/5
- This PR contains a critical typo that will cause the workflow to potentially run when it shouldn't, reducing the effectiveness of the optimization
- Score lowered due to the filename typo in
.git-glame-ignore-revs
which should be.git-blame-ignore-revs
- Pay close attention to the paths-ignore list in
.github/workflows/pr-test-suite.yml
to verify the typo and ensure all intended file patterns are correctly specified
1 file reviewed, 2 comments
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4992 +/- ##
==========================================
+ Coverage 75.33% 76.60% +1.26%
==========================================
Files 929 929
Lines 130509 128392 -2117
==========================================
+ Hits 98319 98354 +35
+ Misses 32190 30038 -2152 🚀 New features to boost your workflow:
|
This reverts commit 8416102.
## Changes Made #4992 had to be reverted because of required checks. We do it for real this time.
## Changes Made Eventual-Inc#4992 had to be reverted because of required checks. We do it for real this time.
## Changes Made Eventual-Inc#4992 had to be reverted because of required checks. We do it for real this time.
Changes Made
Trivial non-code changes are clogging our CI. This needs to stop.