-
Notifications
You must be signed in to change notification settings - Fork 295
fix: correct Modin query optimizer value in comparison tables #4983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed "Eagar" to "Yes" for Modin's Query Optimizer column in both README.rst and engine_comparison.md. Reference: https://modin.readthedocs.io/en/stable/development/architecture.html confirms Modin has a Query Planner and Query Executor that perform optimizations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR fixes a documentation error in the engine comparison tables for Modin's query optimization capabilities. The change corrects "Eagar" to "Yes" (displayed as ✅ in markdown format) in two documentation files that contain comparison tables between Daft and other data processing engines.
The correction serves two purposes: it fixes an obvious typo ("Eagar" appears to be a misspelling of "Eager") and standardizes the value format to match the boolean Yes/No structure used throughout the Query Optimizer column. More importantly, it accurately reflects Modin's actual capabilities - according to Modin's architecture documentation, it does have query optimization features through its Query Planner and Query Executor components.
This change fits within Daft's broader documentation strategy of providing accurate competitive analysis information. The comparison tables appear to be important reference materials for users evaluating different data processing engines, so maintaining factual accuracy is crucial for credibility. The fix ensures consistency across both the main README.rst file and the dedicated engine comparison markdown document in the docs directory.
Confidence score: 5/5
- This PR is safe to merge with minimal risk as it only fixes documentation typos
- Score reflects simple text corrections in documentation files with no code logic changes
- No files require special attention - both changes are straightforward documentation fixes
2 files reviewed, no comments
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4983 +/- ##
==========================================
- Coverage 76.29% 76.07% -0.22%
==========================================
Files 918 922 +4
Lines 128703 127387 -1316
==========================================
- Hits 98195 96916 -1279
+ Misses 30508 30471 -37 🚀 New features to boost your workflow:
|
…al-Inc#4983) ## Summary - Fixed value in Modin's Query Optimizer column from "Eagar" to "Yes" in comparison tables ## Context The tables had "Eagar" for Modin's Query Optimizer capability. Based on Modin's documentation, they do have query optimization through their Query Planner and Query Executor components, so "Yes" is the appropriate value for this column. ## Reference https://modin.readthedocs.io/en/stable/development/architecture.html
…al-Inc#4983) ## Summary - Fixed value in Modin's Query Optimizer column from "Eagar" to "Yes" in comparison tables ## Context The tables had "Eagar" for Modin's Query Optimizer capability. Based on Modin's documentation, they do have query optimization through their Query Planner and Query Executor components, so "Yes" is the appropriate value for this column. ## Reference https://modin.readthedocs.io/en/stable/development/architecture.html
Summary
Context
The tables had "Eagar" for Modin's Query Optimizer capability. Based on Modin's documentation, they do have query optimization through their Query Planner and Query Executor components, so "Yes" is the appropriate value for this column.
Reference
https://modin.readthedocs.io/en/stable/development/architecture.html