chore: add additional context to the runtime stats events #4520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
adds an opaque
context
object that we can use to pass in additional context when emitting the runtimestats events.When using the new flotilla engine, this adds the following additional properties: [plan_id, stage_id, node_id, task_id]
Note for reviewers: (@colin-ho @srilman )
While this PR does introduce the extra information to associate an event back to stages/plans/nodes, it does not yet give us the capability to know the relationship between stages, or between nodes
For example, if we have a stage with 3 pipeline nodes, where (3) depends on both (1) and (2), we have no way to know that as we're not tracking the relationships. This is a very similar problem to #4485. In that case we were able to just walk the tree and get the relationship up front, but with our distributed plans we don't actually know what's going to happen next, so we need to map the relationships as they are formed.
Related Issues
Checklist
docs/mkdocs.yml
navigation