Skip to content

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Jun 11, 2025

Changes Made

Example:

* DistributedLimit
|   Node ID: 1
|   Limit: 10
|
* DistributedScan
|   Node ID: 0
|   Local Plan: PhysicalScan->Project->ActorPoolProject->Limit

Right now it's very simple, and just shows the names of the instructions, e.g. PhysicalScan->Project->ActorPoolProject->Limit.

I can't figure out how to display the local physical plans per pipeline node yet.

Related Issues

Checklist

  • Documented in API Docs (if applicable)
  • Documented in User Guide (if applicable)
  • If adding a new documentation page, doc is added to docs/mkdocs.yml navigation
  • Documentation builds and is formatted properly (tag @/ccmao1130 for docs review)

@github-actions github-actions bot added the feat label Jun 11, 2025
@colin-ho colin-ho marked this pull request as ready for review June 11, 2025 02:26
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 10.98901% with 243 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c5153e6). Learn more about missing BASE report.
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-distributed/src/stage/mod.rs 12.82% 68 Missing ⚠️
...-distributed/src/pipeline_node/in_memory_source.rs 3.33% 29 Missing ⚠️
.../daft-distributed/src/pipeline_node/scan_source.rs 3.57% 27 Missing ⚠️
...daft-distributed/src/pipeline_node/intermediate.rs 3.84% 25 Missing ⚠️
...rc/daft-distributed/src/pipeline_node/actor_udf.rs 0.00% 20 Missing ⚠️
src/daft-distributed/src/pipeline_node/mod.rs 0.00% 19 Missing ⚠️
src/daft-distributed/src/pipeline_node/limit.rs 5.55% 17 Missing ⚠️
daft/dataframe/dataframe.py 6.66% 14 Missing ⚠️
src/daft-local-plan/src/plan.rs 0.00% 12 Missing ⚠️
src/daft-distributed/src/python/mod.rs 0.00% 10 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4517   +/-   ##
=======================================
  Coverage        ?   77.54%           
=======================================
  Files           ?      847           
  Lines           ?   116337           
  Branches        ?        0           
=======================================
  Hits            ?    90208           
  Misses          ?    26129           
  Partials        ?        0           
Files with missing lines Coverage Δ
...rc/daft-distributed/src/pipeline_node/translate.rs 92.37% <100.00%> (ø)
src/daft-distributed/src/plan/mod.rs 60.86% <100.00%> (ø)
src/daft-distributed/src/stage/stage_builder.rs 50.88% <100.00%> (ø)
src/daft-distributed/src/plan/runner.rs 0.00% <0.00%> (ø)
src/daft-distributed/src/python/mod.rs 26.59% <0.00%> (ø)
src/daft-local-plan/src/plan.rs 71.81% <0.00%> (ø)
daft/dataframe/dataframe.py 85.41% <6.66%> (ø)
src/daft-distributed/src/pipeline_node/limit.rs 16.89% <5.55%> (ø)
src/daft-distributed/src/pipeline_node/mod.rs 15.00% <0.00%> (ø)
...rc/daft-distributed/src/pipeline_node/actor_udf.rs 0.00% <0.00%> (ø)
... and 4 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@colin-ho colin-ho merged commit b576543 into main Jun 12, 2025
48 of 49 checks passed
@colin-ho colin-ho deleted the colin/flotilla-explain branch June 12, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant