fix: Use PYTHON_VERSION instead of python3 in Makefile #4499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4499 +/- ##
==========================================
+ Coverage 78.11% 78.13% +0.02%
==========================================
Files 843 843
Lines 114865 114864 -1
==========================================
+ Hits 89723 89746 +23
+ Misses 25142 25118 -24 🚀 New features to boost your workflow:
|
petern48
changed the title
universalmind303
approved these changes
Jun 9, 2025
Jay-ju
pushed a commit
to Jay-ju/Daft
that referenced
this pull request
Jun 10, 2025
…4499) ## Changes Made <!-- Describe what changes were made and why. Include implementation details if necessary. --> In the `make .venv` command, if uv isn't installed, this PR makes it so `PYTHON_VERSION` (currently set to python3.11)is used instead of `python3`. ## Related Issues <!-- Link to related GitHub issues, e.g., "Closes Eventual-Inc#123" --> Closes Eventual-Inc#4498 ## Checklist - [ ] Documented in API Docs (if applicable) - [ ] Documented in User Guide (if applicable) - [ ] If adding a new documentation page, doc is added to `docs/mkdocs.yml` navigation - [ ] Documentation builds and is formatted properly (tag @/ccmao1130 for docs review) Co-authored-by: Peter Nguyen <[email protected]>
Jay-ju
pushed a commit
to Jay-ju/Daft
that referenced
this pull request
Jun 10, 2025
…4499) ## Changes Made <!-- Describe what changes were made and why. Include implementation details if necessary. --> In the `make .venv` command, if uv isn't installed, this PR makes it so `PYTHON_VERSION` (currently set to python3.11)is used instead of `python3`. ## Related Issues <!-- Link to related GitHub issues, e.g., "Closes Eventual-Inc#123" --> Closes Eventual-Inc#4498 ## Checklist - [ ] Documented in API Docs (if applicable) - [ ] Documented in User Guide (if applicable) - [ ] If adding a new documentation page, doc is added to `docs/mkdocs.yml` navigation - [ ] Documentation builds and is formatted properly (tag @/ccmao1130 for docs review) Co-authored-by: Peter Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
In the
make .venvcommand, if uv isn't installed, this PR makes it soPYTHON_VERSION(currently set to python3.11)is used instead ofpython3.Related Issues
Closes #4498
Checklist
docs/mkdocs.ymlnavigation