docs: cleanup docs #4434
Merged
docs: cleanup docs #4434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4434 +/- ##
==========================================
+ Coverage 77.66% 77.71% +0.04%
==========================================
Files 843 844 +1
Lines 112186 112601 +415
==========================================
+ Hits 87128 87505 +377
- Misses 25058 25096 +38 🚀 New features to boost your workflow:
|
kevinzwang
reviewed
May 31, 2025
ccmao1130
force-pushed
the
chanchan/docs-cleanup
branch
from
b5aa73a to
0d38cd0
Compare
kevinzwang
approved these changes
Jun 2, 2025
Comment on lines
+644
to
645
| Most commonly you will be creating expressions by using the [`daft.col()`][daft.expressions.col] function. The following example will create an expressiom referring to a columned named `A` but with every row incremented by 1. | ||
|
|
There was a problem hiding this comment.
hi, super nit but I just saw these typos as I was reading through the docs myself. "expressiom" -> "expression" and "columned" -> "column"
There was a problem hiding this comment.
Good call out! @ccmao1130, can you make a PR to fix some of these typos
There was a problem hiding this comment.
Yes! Will make the changes in #4488
4 tasks
ccmao1130
added a commit
that referenced
this pull request
Jun 13, 2025
## Changes Made File paths for integrations are currently `integrations/...` when they should be in their respective folder `io/...` and `catalogs/...`, moved files accordingly Added redirects from `integrations/...` to `io/...` and `catalogs/...` Added an Integrations Overview page that will link to pages in their respective folders Added `↗` to all external links and all external links open in new tab Typos called out in #4434 See build: https://docs.getdaft.io/en/chanchan-docs-integrations/ ## Related Issues #4313 ## Checklist - [ ] Documented in API Docs (if applicable) - [x] Documented in User Guide (if applicable) - [ ] If adding a new documentation page, doc is added to `docs/mkdocs.yml` navigation - [ ] Documentation builds and is formatted properly (tag @/ccmao1130 for docs review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
See build here: https://www.getdaft.io/projects/docs/en/chanchan-docs-cleanup/ (logo in favicon will update once merged to main)
Checklist
docs/mkdocs.ymlnavigation