Skip to content

Conversation

rchowell
Copy link
Contributor

@rchowell rchowell commented May 14, 2025

Changes Made

Working on a readthedocs build atm, last successful one took 23 mins and we have a 30 min timeout. These changes got the build just under 8 mins.

  • Removed I/O documents (sad)
  • Removed ExpressionVisitor API docs.
  • Added back requirements-doc.txt only for RTD
  • Added back "DataFrame Creation"
  • Removed RTD htmlzip

Timeline

Worklog

Just kicked off a build with redirects removed and typos addressed, https://app.readthedocs.org/projects/getdaft-docs/builds/28174757/

Seems HTMLZip takes a long time, and it isn't required (?). I don't believe we expose the ability to download this zip so it's unused afaik, but please correct me if I'm wrong!

It was introduced here, then PDF caused issues and was removed.

It appears our builds were taking ~10 mins (+/- 5) but then jumped to 23 mins after this change. Then builds starting timing out and failing after this change.

Attempts

Checklist

  • Documented in API Docs (if applicable)
  • Documented in User Guide (if applicable)
  • If adding a new documentation page, doc is added to docs/mkdocs.yml navigation
  • Documentation builds and is formatted properly (tag @/ccmao1130 for docs review)

@rchowell rchowell requested a review from ccmao1130 May 14, 2025 03:30
@github-actions github-actions bot added the docs label May 14, 2025
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (6b855de) to head (1d90f4a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4350   +/-   ##
=======================================
  Coverage   78.40%   78.40%           
=======================================
  Files         823      823           
  Lines      110068   110070    +2     
=======================================
+ Hits        86301    86304    +3     
+ Misses      23767    23766    -1     
Files with missing lines Coverage Δ
daft/catalog/__init__.py 71.12% <100.00%> (ø)
daft/io/__shim.py 86.48% <100.00%> (ø)
daft/io/pushdowns.py 94.53% <ø> (ø)
daft/session.py 65.88% <ø> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rchowell rchowell force-pushed the rchowell/doc-fix branch from df669fd to 33dc360 Compare May 14, 2025 22:09
@rchowell rchowell changed the title docs: adds requirements-doc.txt for readthedocs docs: fix readthedocs timeouts May 14, 2025
@rchowell rchowell enabled auto-merge (squash) May 14, 2025 22:32
@rchowell rchowell merged commit 12a6c0a into main May 14, 2025
55 of 56 checks passed
@rchowell rchowell deleted the rchowell/doc-fix branch May 14, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants