perf: Perform Local Distinct list_agg in count_distinct aggregations #4325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Currently, most of the actual work for count_distinct is done at the finalization step, which only runs on 1 task / thread. Thus, very little parallelism is possible. With this change, Daft will perform a local distinct operation on micro-partitions during the sink phase, which can be done in parallel.
Performance results of running ClickBench Queries 4 & 5 (6 runs each, skipping first) on a M4 Max MacBook Pro w/ 14 cores & 32 GB memory:
Related Issues
Checklist
docs/mkdocs.yml
navigation