Skip to content

Conversation

kevinzwang
Copy link
Member

@kevinzwang kevinzwang commented Jan 8, 2025

resolves #3649

@kevinzwang kevinzwang requested a review from jaychia January 8, 2025 01:17
@github-actions github-actions bot added the fix label Jan 8, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #3651 will improve performances by 11.62%

Comparing kevin/gcs-special-chars (bbedc10) with main (1562569)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main kevin/gcs-special-chars Change
test_tpch_sql[1-in-memory-native-8] 220.2 ms 197.3 ms +11.62%

Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@kevinzwang kevinzwang enabled auto-merge (squash) January 8, 2025 01:55
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.02%. Comparing base (e6c084f) to head (bbedc10).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-io/src/google_cloud.rs 0.00% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3651      +/-   ##
==========================================
- Coverage   78.11%   78.02%   -0.09%     
==========================================
  Files         726      727       +1     
  Lines       89492    89628     +136     
==========================================
+ Hits        69903    69936      +33     
- Misses      19589    19692     +103     
Files with missing lines Coverage Δ
src/daft-io/src/google_cloud.rs 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

@kevinzwang kevinzwang merged commit 426ddd0 into main Jan 8, 2025
13 of 32 checks passed
@kevinzwang kevinzwang deleted the kevin/gcs-special-chars branch January 8, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expression.url.download fails on URLs with special characters
2 participants