Skip to content

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Dec 6, 2024

This test currently fails as we underestimate by 2x

Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #3514 will improve performances by 72.53%

Comparing jay/more-size-estimations (dff1cf9) with main (0889bbf)

Summary

⚡ 2 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark main jay/more-size-estimations Change
test_iter_rows_first_row[100 Small Files] 333 ms 193 ms +72.53%
test_show[100 Small Files] 23.5 ms 17.3 ms +35.77%

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.60%. Comparing base (0889bbf) to head (dff1cf9).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3514   +/-   ##
=======================================
  Coverage   77.59%   77.60%           
=======================================
  Files         707      707           
  Lines       86172    86174    +2     
=======================================
+ Hits        66867    66873    +6     
+ Misses      19305    19301    -4     

see 3 files with indirect coverage changes

Copy link
Collaborator

@desmondcheongzx desmondcheongzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test currently fails as we underestimate by 2x

😅

@jaychia jaychia merged commit 6390afa into main Dec 9, 2024
44 checks passed
@jaychia jaychia deleted the jay/more-size-estimations branch December 9, 2024 20:47
raunakab pushed a commit that referenced this pull request Dec 10, 2024
This test currently fails as we underestimate by 2x

Co-authored-by: Jay Chia <[email protected]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants