Skip to content

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Dec 4, 2024

No description provided.

@colin-ho colin-ho changed the title block on the fut [BUG] Block on parquet schema future in estimate_size_bytes Dec 4, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 4, 2024
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #3484 will improve performances by ×2.1

Comparing colin/fix-size-bytes-estimation (1ce60b2) with main (75ad85a)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main colin/fix-size-bytes-estimation Change
test_show[100 Small Files] 34.3 ms 16.3 ms ×2.1

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.39%. Comparing base (75ad85a) to head (1ce60b2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-scan/src/python.rs 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3484      +/-   ##
==========================================
- Coverage   77.43%   77.39%   -0.04%     
==========================================
  Files         696      696              
  Lines       84497    84549      +52     
==========================================
+ Hits        65429    65438       +9     
- Misses      19068    19111      +43     
Files with missing lines Coverage Δ
src/daft-scan/src/python.rs 69.56% <0.00%> (-7.43%) ⬇️

... and 1 file with indirect coverage changes

@desmondcheongzx desmondcheongzx merged commit 83470e0 into main Dec 4, 2024
44 of 46 checks passed
@desmondcheongzx desmondcheongzx deleted the colin/fix-size-bytes-estimation branch December 4, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants