Skip to content

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Nov 28, 2024

Fixes: #3450

@github-actions github-actions bot added the bug Something isn't working label Nov 28, 2024
@colin-ho colin-ho requested a review from jaychia November 28, 2024 19:57
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #3451 will improve performances by 14.06%

Comparing colin/fix-s3-lance (ff41687) with main (f2d4f73)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main colin/fix-s3-lance Change
test_iter_rows_first_row[100 Small Files] 304.2 ms 266.7 ms +14.06%

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (b6eee0b) to head (ff41687).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3451      +/-   ##
==========================================
+ Coverage   77.37%   77.50%   +0.12%     
==========================================
  Files         684      687       +3     
  Lines       83694    84474     +780     
==========================================
+ Hits        64756    65469     +713     
- Misses      18938    19005      +67     
Files with missing lines Coverage Δ
daft/dataframe/dataframe.py 86.91% <100.00%> (+0.26%) ⬆️

... and 53 files with indirect coverage changes

@colin-ho colin-ho merged commit 48284a8 into main Nov 28, 2024
46 checks passed
@colin-ho colin-ho deleted the colin/fix-s3-lance branch November 28, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to write_lance to S3 (minio)
2 participants