Skip to content

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Nov 13, 2024

No description provided.

@jaychia jaychia enabled auto-merge (squash) November 13, 2024 18:23
@github-actions github-actions bot added the chore label Nov 13, 2024
@jaychia jaychia disabled auto-merge November 13, 2024 18:25
@jaychia jaychia merged commit 769ec98 into main Nov 13, 2024
21 of 22 checks passed
@jaychia jaychia deleted the jaychia-patch-1 branch November 13, 2024 18:25
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #3283 will degrade performances by 14.69%

Comparing jaychia-patch-1 (6e14515) with main (d978058)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jaychia-patch-1 Change
test_iter_rows_first_row[100 Small Files] 326.4 ms 276.6 ms +18.01%
test_show[100 Small Files] 34.8 ms 40.8 ms -14.69%

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.41%. Comparing base (d978058) to head (6e14515).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
- Coverage   77.69%   77.41%   -0.28%     
==========================================
  Files         666      665       -1     
  Lines       81131    81932     +801     
==========================================
+ Hits        63037    63431     +394     
- Misses      18094    18501     +407     

see 15 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant