[CHORE] Fix flaky test in test_decimal_to_decimal_cast #3243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3243 will not alter performanceComparing Summary
|
samster25
reviewed
Nov 7, 2024
| @@ -2352,6 +2352,9 @@ mod tests { | |||
|
|
|||
| let scale: usize = rng.gen_range(0..=MAX_SCALE); | |||
There was a problem hiding this comment.
would it simpler to set the lower bound for scale to 1 instead?
There was a problem hiding this comment.
I considered that too. I think 0 is a valid scale, thus I prefer to include that in the test.
WDYT? I'm OK to set the lower bound to 1.
There was a problem hiding this comment.
IMO keeping the lower bound of the scale to 0 is fine.
I would say instead of doing EPSILON * factor below, simply doing
let epsilon = if scale == 0 { 1.0 } else { 0.1 };
would be easier
There was a problem hiding this comment.
Good point, let me fix it.
There was a problem hiding this comment.
Thanks! Looks good
advancedxy
force-pushed
the
fix_flaky_test
branch
from
7cf339b to
41ac479
Compare
desmondcheongzx
approved these changes
Nov 7, 2024
| @@ -2352,6 +2352,9 @@ mod tests { | |||
|
|
|||
| let scale: usize = rng.gen_range(0..=MAX_SCALE); | |||
There was a problem hiding this comment.
Thanks! Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this failure on another PR's CI run: https://github.com/Eventual-Inc/Daft/actions/runs/11715735385/job/32632612788?pr=3134
This is a flaky test and should be fixed.