Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix reading of logical types from Parquet files in s3 #3026

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Oct 10, 2024

  • The inferred schema from a Parquet file includes logical types
  • However, when reading Series from the Parquet file, we read the "arrow types" from the Parquet schema
  • This causes the Table to crap itself because the schemas don't match (we try to pass in the inferred schema with logical types but it doesn't match the Series types which are inferred from arrow types on the Parquet file)

@jaychia jaychia requested a review from colin-ho October 10, 2024 22:41
@github-actions github-actions bot added the bug Something isn't working label Oct 10, 2024
Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #3026 will not alter performance

Comparing jay/fix-logical-reads-parquet (ab9a79e) with main (73ff3f3)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.37%. Comparing base (73ff3f3) to head (ab9a79e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3026      +/-   ##
==========================================
+ Coverage   78.14%   78.37%   +0.22%     
==========================================
  Files         610      610              
  Lines       72146    71987     -159     
==========================================
+ Hits        56381    56422      +41     
+ Misses      15765    15565     -200     
Files with missing lines Coverage Δ
src/daft-parquet/src/file.rs 73.90% <100.00%> (-0.08%) ⬇️

... and 17 files with indirect coverage changes

@colin-ho colin-ho merged commit 9ae8122 into main Oct 10, 2024
43 checks passed
@colin-ho colin-ho deleted the jay/fix-logical-reads-parquet branch October 10, 2024 23:13
colin-ho added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants