Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: SQL add hash and minhash #2948

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

universalmind303
Copy link
Collaborator

add a few more missing scalars (hash and minhash)

@github-actions github-actions bot added the enhancement New feature or request label Sep 26, 2024
Copy link

codspeed-hq bot commented Sep 26, 2024

CodSpeed Performance Report

Merging #2948 will not alter performance

Comparing universalmind303:sql-hashing (4d5ae1e) with main (0525bb9)

Summary

✅ 17 untouched benchmarks

@jaychia jaychia removed their request for review September 26, 2024 20:41
Copy link
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a couple of questions.

src/daft-sql/src/modules/hashing.rs Show resolved Hide resolved
src/daft-sql/src/modules/hashing.rs Show resolved Hide resolved
src/daft-sql/src/modules/hashing.rs Show resolved Hide resolved
src/daft-sql/src/modules/hashing.rs Show resolved Hide resolved
Copy link
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@universalmind303 universalmind303 merged commit f1194b5 into Eventual-Inc:main Sep 30, 2024
36 checks passed
sagiahrac pushed a commit to sagiahrac/Daft that referenced this pull request Oct 7, 2024
add a few more missing scalars (hash and minhash)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants