[BUG] improve error reporting for multistatement sql #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
universalmind303
approved these changes
Sep 25, 2024
|
@amitschang it looks like there's some merge conflicts. Once these are resolved, this should be good to merge! |
amitschang
force-pushed
the
sql-multistatement-error-fix
branch
from
c398ff5
to
3b9a1ad
Compare
|
@universalmind303 thanks! I rebased on the latest origin/main - actually didn't encounter a conflict somehow |
CodSpeed Performance ReportMerging #2916 will not alter performanceComparing Summary
|
sagiahrac
pushed a commit
to sagiahrac/Daft
that referenced
this pull request
Oct 7, 2024
Called it a bug because the error is confusing, this fixes error
behavior of multistatement sql. Before:
```py
daft.sql('''SELECT * FROM df; SELECT count(*) FROM df''', cat)
```
results in this error:
```py
daft.exceptions.InvalidSQLException: Unsupported SQL: 'SELECT * FROM df'
```
but of course that SQL is supported! With this change, error becomes:
```py
daft.exceptions.InvalidSQLException: Unsupported SQL: 'Only exactly one SQL statement allowed, found 2'
```
which I believe is at least currently correct, and any future support of
multiple statements would have to touch this area of code anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Called it a bug because the error is confusing, this fixes error behavior of multistatement sql. Before:
results in this error:
but of course that SQL is supported! With this change, error becomes:
which I believe is at least currently correct, and any future support of multiple statements would have to touch this area of code anyway.