Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Enable sources to return empty tables #2915

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

colin-ho
Copy link
Contributor

Sources in the native executor should still return empty tables if they didn't read anything.

This unlocks a bunch of tests.

@github-actions github-actions bot added the chore label Sep 25, 2024
Copy link

codspeed-hq bot commented Sep 25, 2024

CodSpeed Performance Report

Merging #2915 will not alter performance

Comparing colin/swordfish-empty-dfs (9aaac3f) with main (a9fdd19)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.38%. Comparing base (a9fdd19) to head (9aaac3f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-local-execution/src/sources/in_memory.rs 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2915      +/-   ##
==========================================
+ Coverage   77.57%   78.38%   +0.81%     
==========================================
  Files         596      596              
  Lines       70687    69685    -1002     
==========================================
- Hits        54835    54626     -209     
+ Misses      15852    15059     -793     
Flag Coverage Δ
78.38% <83.33%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/daft-local-execution/src/pipeline.rs 91.32% <100.00%> (+0.07%) ⬆️
src/daft-local-execution/src/sources/scan_task.rs 91.53% <ø> (ø)
src/daft-local-execution/src/sources/in_memory.rs 90.90% <66.66%> (-9.10%) ⬇️

... and 20 files with indirect coverage changes

@colin-ho colin-ho merged commit b1ea3b9 into main Sep 25, 2024
40 checks passed
@colin-ho colin-ho deleted the colin/swordfish-empty-dfs branch September 25, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants