Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Sql groupby fix #2843

Merged
merged 15 commits into from
Sep 17, 2024

Conversation

universalmind303
Copy link
Collaborator

addresses #2835

@universalmind303 universalmind303 changed the title [FIX]: Sql groupby fix [BUG]: Sql groupby fix Sep 13, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 13, 2024
Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #2843 will degrade performances by 69.77%

Comparing universalmind303:sql-groupby-fix (596cfab) with main (6594d87)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:sql-groupby-fix Change
test_count[1 Small File] 22.8 ms 11.2 ms ×2
test_show[100 Small Files] 49.6 ms 164.2 ms -69.77%

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One thing I'm wondering is what the behavior should be when grouping by something that is not just a column, such as SELECT * FROM table GROUP BY a + b. Right now it errors but the error messages come from the logical plan builder and do not really make sense in the context of the SQL query itself. Perhaps we just disallow it explicitly.

tests/sql/test_sql.py Show resolved Hide resolved
@universalmind303 universalmind303 enabled auto-merge (squash) September 17, 2024 14:55
@universalmind303 universalmind303 merged commit 07e92f6 into Eventual-Inc:main Sep 17, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants