Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Remove enum imports daft core #2819

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Sep 9, 2024

Overview

  • removed all instances of use MyEnum::*; from daft-core
  • using that pattern has a huge chance of hard-to-catch bugs being created in the future

@github-actions github-actions bot added the chore label Sep 9, 2024
@raunakab
Copy link
Contributor Author

raunakab commented Sep 9, 2024

Run the following grep in the daft-core subdir:

rg "use [\w]*::\*;"

You'll notice that no instances (other than use super::*) appear. This is as expected.

@raunakab raunakab marked this pull request as ready for review September 9, 2024 21:55
Copy link

codspeed-hq bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #2819 will not alter performance

Comparing ronnie/remove-enum-imports-daft-core (354e67f) with main (08ca9a4)

Summary

✅ 16 untouched benchmarks

@raunakab raunakab merged commit 7bee225 into main Sep 9, 2024
37 checks passed
@raunakab raunakab deleted the ronnie/remove-enum-imports-daft-core branch September 9, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant