Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add grouping and aggregation docs #2805

Merged
merged 2 commits into from
Sep 6, 2024
Merged

[DOCS] Add grouping and aggregation docs #2805

merged 2 commits into from
Sep 6, 2024

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Sep 6, 2024

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 6, 2024
Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #2805 will degrade performances by 55.01%

Comparing colin/agg-docs (6e07974) with main (b61349b)

Summary

❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main colin/agg-docs Change
test_show[100 Small Files] 50.6 ms 112.5 ms -55.01%

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@b61349b). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2805   +/-   ##
=======================================
  Coverage        ?   63.28%           
=======================================
  Files           ?     1007           
  Lines           ?   114178           
  Branches        ?        0           
=======================================
  Hits            ?    72253           
  Misses          ?    41925           
  Partials        ?        0           

@colin-ho colin-ho changed the title [DOCS] Add approx count distinct to docs [DOCS] Add grouping and aggregation docs Sep 6, 2024
@colin-ho colin-ho merged commit e69b089 into main Sep 6, 2024
36 of 37 checks passed
@colin-ho colin-ho deleted the colin/agg-docs branch September 6, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants