Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Casting matrix #2801

Merged
merged 2 commits into from
Sep 6, 2024
Merged

[DOCS] Casting matrix #2801

merged 2 commits into from
Sep 6, 2024

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Sep 6, 2024

Screenshot 2024-09-06 at 11 55 31 AM

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 6, 2024
Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #2801 will degrade performances by 13.36%

Comparing colin/casting-matrix (6ad9fe4) with main (e3fbf88)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main colin/casting-matrix Change
test_count[1 Small File] 20.5 ms 23.6 ms -13.36%
test_show[100 Small Files] 298.8 ms 48.7 ms ×6.1

Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test or something that can help us validate this?

@colin-ho
Copy link
Contributor Author

colin-ho commented Sep 6, 2024

is there a test or something that can help us validate this?

We don't have a centralized location for testing all possible casting combinations yet. The best is tests/series/test_cast.py but this is limited to certain dtypes only.

I'll augment that file to make sure it covers everything, and then it can serve as our 'Master' casting validation test file.

@colin-ho colin-ho merged commit b61349b into main Sep 6, 2024
34 of 35 checks passed
@colin-ho colin-ho deleted the colin/casting-matrix branch September 6, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants