[BUG] Propogate S3Config.num_tries to pyarrow S3 filesystem #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmurray-clarify
changed the title
CodSpeed Performance ReportMerging #2800 will improve performances by 32.95%Comparing Summary
Benchmarks breakdown
|
jmurray-clarify
force-pushed
the
jmurray-clarify/2788-pyarrow-s3-retries
branch
from
47f7fa1
to
6b7f836
Compare
samster25
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #2788
Propogates the S3Config.num_tries config to the pyarrow S3 filesystem.
Note that the other relevant parameters on S3Config,
retry_modeandretry_initial_backoff_ms, are ignored as pyarrow's S3RetryStrategy only has one parametermax_attempts.Note that this only addresses S3. GCSConfig and AzureConfig do not have retry settings.