Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add derive_more to get rid of manual Display impls #2794

Merged
merged 11 commits into from
Sep 9, 2024

Merge branch 'main' into ronnie/cleanup-display-impls

8ee4db5
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] Add derive_more to get rid of manual Display impls #2794

Merge branch 'main' into ronnie/cleanup-display-impls
8ee4db5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 9, 2024 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 93.33333% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d30e62a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/daft-dsl/src/functions/mod.rs 93.33% 2 Missing ⚠️
src/daft-core/src/join.rs 50.00% 1 Missing ⚠️
src/daft-schema/src/field.rs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2794   +/-   ##
=======================================
  Coverage        ?   63.31%           
=======================================
  Files           ?     1008           
  Lines           ?   114154           
  Branches        ?        0           
=======================================
  Hits            ?    72282           
  Misses          ?    41872           
  Partials        ?        0           
Files with missing lines Coverage Δ
daft/expressions/expressions.py 93.50% <ø> (ø)
src/common/display/src/table_display.rs 81.71% <100.00%> (ø)
src/daft-core/src/count_mode.rs 8.69% <100.00%> (ø)
src/daft-core/src/series/mod.rs 98.50% <ø> (ø)
src/daft-dsl/src/expr.rs 75.84% <100.00%> (ø)
src/daft-schema/src/dtype.rs 80.60% <100.00%> (ø)
src/daft-schema/src/image_format.rs 56.00% <100.00%> (ø)
src/daft-schema/src/image_mode.rs 50.00% <100.00%> (ø)
src/daft-schema/src/schema.rs 87.44% <100.00%> (ø)
src/daft-schema/src/time_unit.rs 95.45% <100.00%> (ø)
... and 3 more