Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix set_execution_config not setting hash_join_partition_size_leniency #2759

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Vince7778
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Aug 28, 2024
@Vince7778 Vince7778 enabled auto-merge (squash) August 29, 2024 00:04
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.11%. Comparing base (372d9bc) to head (855a738).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2759      +/-   ##
==========================================
+ Coverage   63.08%   63.11%   +0.03%     
==========================================
  Files         994      994              
  Lines      113416   113416              
==========================================
+ Hits        71548    71586      +38     
+ Misses      41868    41830      -38     
Files with missing lines Coverage Δ
daft/context.py 75.64% <ø> (ø)

... and 20 files with indirect coverage changes

@Vince7778 Vince7778 merged commit 3c365e6 into main Aug 29, 2024
36 checks passed
@Vince7778 Vince7778 deleted the conor/hash-join-config branch August 29, 2024 00:10
Copy link

codspeed-hq bot commented Aug 29, 2024

CodSpeed Performance Report

Merging #2759 will improve performances by 61.31%

Comparing conor/hash-join-config (855a738) with main (372d9bc)

Summary

⚡ 1 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark main conor/hash-join-config Change
test_show[100 Small Files] 723.3 ms 448.4 ms +61.31%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants