Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add .lldbinit for debugging #2750

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[CHORE] Add .lldbinit for debugging #2750

merged 1 commit into from
Aug 28, 2024

Conversation

kevinzwang
Copy link
Member

No description provided.

Copy link

codspeed-hq bot commented Aug 27, 2024

CodSpeed Performance Report

Merging #2750 will degrade performances by 59.69%

Comparing kevin/lldbinit (fb5e52a) with main (61f1e44)

Summary

❌ 2 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kevin/lldbinit Change
test_explain[1 Small File] 6.8 ms 16.8 ms -59.69%
test_show[100 Small Files] 386.3 ms 693.9 ms -44.33%

Copy link
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested locally yet, but looks good to me based off of inspection.

LGTM!

@kevinzwang kevinzwang merged commit 2e8841d into main Aug 28, 2024
34 of 35 checks passed
@kevinzwang kevinzwang deleted the kevin/lldbinit branch August 28, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants