Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] add large fake files for benchmarks (disabled) #2744

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

samster25
Copy link
Member

No description provided.

@github-actions github-actions bot added the chore label Aug 27, 2024
Copy link

codspeed-hq bot commented Aug 27, 2024

CodSpeed Performance Report

Merging #2744 will improve performances by 23.29%

Comparing sammy/add-large-fake-data-tests (1b7466e) with main (ec741ac)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main sammy/add-large-fake-data-tests Change
test_explain[1 Small File] 5.8 ms 4.7 ms +23.29%

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.08%. Comparing base (f6c2cd0) to head (1b7466e).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2744      +/-   ##
==========================================
- Coverage   63.36%   63.08%   -0.29%     
==========================================
  Files         981      981              
  Lines      113251   113258       +7     
==========================================
- Hits        71762    71447     -315     
- Misses      41489    41811     +322     

see 27 files with indirect coverage changes

@samster25 samster25 merged commit f21ca7a into main Aug 27, 2024
36 checks passed
@samster25 samster25 deleted the sammy/add-large-fake-data-tests branch August 27, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant