[BUG] Add a with_execution/planning_config context manager and fix tests for splitting of parquet #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaychia
commented
Aug 22, 2024
•
jaychia
commented
- Adds a context manager to perform overrides of the configs that will reset themselves afterwards
- Adds some fixes for splitting of Parquet files
CodSpeed Performance ReportMerging #2713 will not alter performanceComparing Summary
|
jaychia
force-pushed
the
jay/disable-autouse-parquet-flags-conftesrt
branch
from
2402804
to
66a947c
Compare
added 2 commits
August 22, 2024 16:16
|
added the fix here, also had to modify some of the sql tests because the scan task merging affects it |
github-actions
bot
added
the
documentation
jaychia
changed the title
colin-ho
approved these changes
Aug 23, 2024
daft/runners/ray_runner.py
Outdated
| @@ -350,8 +350,10 @@ def single_partition_pipeline( | |||
| partial_metadatas: list[PartitionMetadata], | |||
| *inputs: MicroPartition, | |||
| ) -> list[list[PartitionMetadata] | MicroPartition]: | |||
| set_execution_config(daft_execution_config) | |||
| return build_partitions(instruction_stack, partial_metadatas, *inputs) | |||
| with with_execution_config( | |||
There was a problem hiding this comment.
Nit: could we change with_execution_config to something like daft_execution_context . currently the with with_execution_config has a double with with that looks a little weird on first glance
There was a problem hiding this comment.
Yeah I agree, changed to *_config_ctx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.