[BUG] Use python logging level

[colin-ho]

Example script:

import daft
print("Only warnings and errors should print")
daft.daft.test_logging()

print("\nSetting logging level to debug, all messages should print")
from daft.logging import setup_debug_logger
setup_debug_logger()
daft.daft.test_logging()

Output:

Only warnings and errors should print
WARN from rust
ERROR from rust

Setting logging level to debug, all messages should print
DEBUG:daft.pylib:DEBUG from rust
INFO:daft.pylib:INFO from rust
WARNING:daft.pylib:WARN from rust
ERROR:daft.pylib:ERROR from rust

[samster25]

We should only create the logger and install it on the first run.
Currently if the user calls refresh_logger in python it panics.

import daft
daft.refresh_logger()

# PanicException: called `Result::unwrap()` on an `Err` value: SetLoggerError(())

[samster25]

You should be able to put everything above in a function and then call that in the get_or_init

let func = || {
        use log::LevelFilter;
        let logging = py.import("logging")?;
        let python_log_level = logging
        ... 

        logger.install().unwrap()
}

LOG_RESET_HANDLE.get_or_init(func).reset();

[samster25]

this will ensure that we only init once and that it's reset every time it's called

[samster25]

also let's add a test for that

[codspeed-hq]

CodSpeed Performance Report

Merging #2705 will not alter performance

_{Comparing colin/logging (a2971c8) with main (3647b26)}

Summary

✅ 10 untouched benchmarks

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.39%. Comparing base (b3f5260) to head (d109504).
Report is 4 commits behind head on main.

Files	Patch %	Lines
src/lib.rs	90.90%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2705      +/-   ##
==========================================
- Coverage   63.52%   63.39%   -0.13%     
==========================================
  Files         979      978       -1     
  Lines      112148   112180      +32     
==========================================
- Hits        71239    71119     -120     
- Misses      40909    41061     +152     

Files	Coverage Δ
src/lib.rs	92.42% <90.90%> (-1.20%)	⬇️

... and 64 files with indirect coverage changes

[samster25]

it might be cleaner to have this return the max log level instead as get_max_log_level()