Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Add runner logic in PyRunner for ActorPoolProject #2677

Merged
merged 8 commits into from
Sep 5, 2024
Merged

[FEAT] Add runner logic in PyRunner for ActorPoolProject #2677

merged 8 commits into from
Sep 5, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Aug 16, 2024 •
edited
Loading

Adds remaining logic for linking the ActorPoolProject physical plan with execution logic in the PyRunner

@jaychia jaychia force-pushed the jay/stateful-udf-4 branch 2 times, most recently from b8d5fed to d436e1a Compare August 19, 2024 14:50
@jaychia jaychia force-pushed the jay/feature-flag-stateful-actors branch from 291189b to 58e6589 Compare August 19, 2024 14:50
@jaychia jaychia force-pushed the jay/feature-flag-stateful-actors branch from 58e6589 to 42d08b6 Compare August 19, 2024 15:05
@jaychia jaychia force-pushed the jay/feature-flag-stateful-actors branch from 42d08b6 to 6bbee35 Compare August 20, 2024 14:34
@jaychia jaychia force-pushed the jay/feature-flag-stateful-actors branch from 6bbee35 to 58e1450 Compare August 23, 2024 22:31
Base automatically changed from jay/feature-flag-stateful-actors to main August 26, 2024 18:56
@github-actions github-actions bot added the enhancement New feature or request label Aug 26, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 28, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2677 will not alter performance

Comparing jay/stateful-udf-4 (bf88e8a) with main (c6afd78)

Summary

✅ 16 untouched benchmarks

kevinzwang
kevinzwang reviewed Aug 31, 2024
View reviewed changes
Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

daft/execution/physical_plan.py Show resolved Hide resolved
daft/runners/pyrunner.py Show resolved Hide resolved
src/daft-dsl/src/functions/python/udf_runtime_binding.rs Show resolved Hide resolved
tests/actor_pool/test_ray_actor_pool.py Outdated Show resolved Hide resolved
daft/runners/runner.py Outdated Show resolved Hide resolved
daft/execution/physical_plan.py Show resolved Hide resolved
daft/runners/pyrunner.py Show resolved Hide resolved
@jaychia jaychia changed the title [FEAT] (ACTORS-4) Add runner logic in PyRunner and RayRunner [FEAT] Add runner logic in PyRunner for ActorPoolProject Sep 2, 2024
@jaychia jaychia marked this pull request as ready for review September 2, 2024 23:23
@jaychia jaychia mentioned this pull request Sep 2, 2024
Closed
@jaychia jaychia enabled auto-merge (squash) September 2, 2024 23:56
@jaychia jaychia merged commit 8a5170f into main Sep 5, 2024
35 checks passed
@jaychia jaychia deleted the jay/stateful-udf-4 branch September 5, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinzwang kevinzwang kevinzwang left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaychia @kevinzwang