-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Add error snafus for local executor #2660
Conversation
ae132b9
to
99c299f
Compare
Error::PipelineCreationError { .. } | Error::PipelineExecutionError { .. } => { | ||
DaftError::InternalError(err.to_string()) | ||
} | ||
_ => DaftError::External(err.into()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't want to nest the execution error under DaftError::External
otherwise the conversion of the DaftError to the correct PythonError won't happen.
For now, we can unnest the daft error, log where it came from and then return that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done and updated PR description example. Assumed you meant not to nest DaftErrors under DaftError::InternalError
, the Externals are for the tokio oneshot and join errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh whoops, yeah looks good now!
Example: