Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add input batching for UDFs #2651

Merged
merged 3 commits into from
Aug 14, 2024
Merged

[FEAT] Add input batching for UDFs #2651

merged 3 commits into from
Aug 14, 2024

Conversation

Vince7778
Copy link
Contributor

Lets you specify a batch size for your UDFs, and then inputs are split up into batches of at most that size before being passed in to the UDF.

@github-actions github-actions bot added the enhancement New feature or request label Aug 14, 2024
@jaychia jaychia self-requested a review August 14, 2024 17:24
daft/expressions/expressions.py Show resolved Hide resolved
daft/udf.py Show resolved Hide resolved
src/daft-dsl/src/python.rs Outdated Show resolved Hide resolved
daft/udf.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 89.71963% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.82%. Comparing base (6821325) to head (fd9184e).
Report is 5 commits behind head on main.

Files Patch % Lines
daft/udf.py 92.98% 4 Missing ⚠️
src/daft-dsl/src/functions/python/mod.rs 50.00% 4 Missing ⚠️
src/daft-dsl/src/python.rs 83.33% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2651      +/-   ##
==========================================
+ Coverage   63.79%   63.82%   +0.02%     
==========================================
  Files         972      976       +4     
  Lines      111101   111223     +122     
==========================================
+ Hits        70882    70985     +103     
- Misses      40219    40238      +19     
Files Coverage Δ
daft/expressions/expressions.py 93.75% <100.00%> (+0.01%) ⬆️
src/daft-dsl/src/functions/python/udf.rs 78.39% <100.00%> (+2.36%) ⬆️
...logical_optimization/rules/push_down_projection.rs 84.07% <100.00%> (+0.04%) ⬆️
src/daft-dsl/src/python.rs 94.08% <83.33%> (-0.32%) ⬇️
daft/udf.py 93.59% <92.98%> (-0.69%) ⬇️
src/daft-dsl/src/functions/python/mod.rs 63.46% <50.00%> (-0.73%) ⬇️

... and 38 files with indirect coverage changes

Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Vince7778 Vince7778 merged commit ab557b5 into main Aug 14, 2024
46 checks passed
@Vince7778 Vince7778 deleted the conor/udf-batching branch August 14, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants