Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Example Analyze for Local Execution Engine #2648

Merged
merged 23 commits into from
Aug 16, 2024
Merged

[FEAT] Example Analyze for Local Execution Engine #2648

merged 23 commits into from
Aug 16, 2024

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Aug 13, 2024 •
edited
Loading

image

@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.78723% with 358 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e048a45). Learn more about missing BASE report.
Report is 7 commits behind head on main.

Files Patch % Lines
src/daft-local-execution/src/runtime_stats.rs 0.00% 80 Missing ⚠️
src/daft-local-execution/src/sources/source.rs 0.00% 44 Missing ⚠️
src/daft-local-execution/src/sinks/hash_join.rs 0.00% 42 Missing ⚠️
src/daft-parquet/src/stream_reader.rs 0.00% 38 Missing ⚠️
...c/daft-local-execution/src/sinks/streaming_sink.rs 0.00% 35 Missing ⚠️
...rc/daft-local-execution/src/sinks/blocking_sink.rs 0.00% 34 Missing ⚠️
...-execution/src/intermediate_ops/intermediate_op.rs 0.00% 32 Missing ⚠️
src/daft-local-execution/src/run.rs 0.00% 16 Missing ⚠️
src/common/display/src/utils.rs 0.00% 14 Missing ⚠️
src/daft-local-execution/src/pipeline.rs 0.00% 10 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2648   +/-   ##
=======================================
  Coverage        ?   63.54%           
=======================================
  Files           ?      981           
  Lines           ?   111968           
  Branches        ?        0           
=======================================
  Hits            ?    71153           
  Misses          ?    40815           
  Partials        ?        0
Files Coverage Δ
src/common/display/src/lib.rs 0.00% <ø> (ø)
src/daft-io/src/stats.rs 90.36% <100.00%> (ø)
src/daft-local-execution/src/lib.rs 14.28% <ø> (ø)
src/daft-plan/src/display.rs 94.26% <100.00%> (ø)
src/common/display/src/mermaid.rs 97.67% <93.75%> (ø)
src/daft-parquet/src/read.rs 69.50% <0.00%> (ø)
src/daft-local-execution/src/sinks/sort.rs 0.00% <0.00%> (ø)
src/daft-local-execution/src/sources/scan_task.rs 0.00% <0.00%> (ø)
src/daft-local-execution/src/sources/in_memory.rs 0.00% <0.00%> (ø)
src/daft-local-execution/src/pipeline.rs 0.00% <0.00%> (ø)
... and 9 more

colin-ho
colin-ho approved these changes Aug 16, 2024
View reviewed changes
src/daft-local-execution/src/sinks/blocking_sink.rs Outdated
_ => {
let rt_result = self.runtime_stats.result();
writeln!(display).unwrap();
writeln!(display, "rows received = {}", rt_result.rows_received).unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we format the numbers more prettily? maybe using something like https://docs.rs/num-format/latest/num_format/#

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/daft-local-execution/src/sources/source.rs Outdated

writeln!(display).unwrap();
writeln!(display, "rows emitted = {}", rt_result.rows_emitted).unwrap();
writeln!(display, "bytes read = {}", self.io_stats.load_bytes_read()).unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maybe want to pretty format based on the size? i.e. GB if bytes >= 1024^3, MB if bytes >= 1024^2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@samster25 samster25 changed the title Sammy/viz pipeline [FEAT] Example Analyze for Local Execution Engine Aug 16, 2024
@github-actions github-actions bot added the enhancement New feature or request label Aug 16, 2024
@samster25 samster25 marked this pull request as ready for review August 16, 2024 22:25
@samster25 samster25 enabled auto-merge (squash) August 16, 2024 22:36
@samster25 samster25 merged commit b15b0c7 into main Aug 16, 2024
44 checks passed
@samster25 samster25 deleted the sammy/viz-pipeline branch August 16, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-ho colin-ho colin-ho approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samster25 @colin-ho