Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: refactor tree display to get more info into physicalplan #2640

Merged

Conversation

universalmind303
Copy link
Collaborator

@universalmind303 universalmind303 commented Aug 12, 2024

closes #2617

before

== Physical Plan ==

* Limit: 10
|   Eager = false
|   Num partitions = 53
|
* TabularScan:
|   Num Scan Tasks = 53
|   Estimated Scan Bytes = 11569347231
|   Clustering spec = { Num partitions = 53 }

after

== Physical Plan ==

* Limit: 10
|   Eager = false
|   Num partitions = 52
|
* TabularScan:
|   Num Scan Tasks = 52
|   Estimated Scan Bytes = 11569347231
|   Clustering spec = { Num partitions = 52 }
|   Pushdowns = {projection: [text], filter: contains(col(text), lit("hello")),
|     limit: 10}
|   id#Utf8, url#Utf8, title#Utf8, text#Utf8
|   Scan Tasks: [
|   {File {file:///Users/me/Development/datasets/wiki/7327c6b8-97b4-4124-
|     a0a7-d131fb1bff0c-0.parquet}}
|   {File {file:///Users/me/Development/datasets/wiki/828a3929-d460-445a-
|     95c5-6618b576edd0-0.parquet}}
|   {File {file:///Users/me/Development/datasets/wiki/e720de08-36e8-463f-
|     adf2-40f46e250744-0.parquet}}
|   ...
|   {File {file:///Users/me/Development/datasets/wiki/918ff71f-7a64-4499-
|     be57-efbc296911ce-0.parquet}}
|   {File {file:///Users/me/Development/datasets/wiki/6dd2cdde-9e96-41e9-
|     9d4b-f50f16cccdb0-0.parquet}, File {file:///Users/me/Development/
|     datasets/wiki/be3425ab-e1e1-45fc-a3a4-5951ad18f262-0.parquet}}
|   {File {file:///Users/me/Development/datasets/wiki/033bae1c-cb75-420d-
|     ac47-d701b42fe15a-0.parquet}}
|   ]

I think there's a LOT more we can do to customize the displays for the plans, but this should at least set up the ground work.

@universalmind303 universalmind303 changed the title [REFACTOR]: tree display [CHORE]: refactor tree display Aug 12, 2024
@github-actions github-actions bot added the chore label Aug 12, 2024
@universalmind303 universalmind303 changed the title [CHORE]: refactor tree display [FEAT]: refactor tree display to get more info into physicalplan Aug 12, 2024
@github-actions github-actions bot added the enhancement New feature or request label Aug 12, 2024
src/daft-plan/src/display.rs Outdated Show resolved Hide resolved
@universalmind303 universalmind303 enabled auto-merge (squash) August 15, 2024 20:40
@universalmind303 universalmind303 merged commit e048a45 into Eventual-Inc:main Aug 15, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add more info to physical plan display
2 participants