-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT]: refactor tree display to get more info into physicalplan #2640
Merged
universalmind303
merged 21 commits into
Eventual-Inc:main
from
universalmind303:multiline-display-impl
Aug 15, 2024
Merged
[FEAT]: refactor tree display to get more info into physicalplan #2640
universalmind303
merged 21 commits into
Eventual-Inc:main
from
universalmind303:multiline-display-impl
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
universalmind303
changed the title
[REFACTOR]: tree display
[CHORE]: refactor tree display
Aug 12, 2024
universalmind303
changed the title
[CHORE]: refactor tree display
[FEAT]: refactor tree display to get more info into physicalplan
Aug 12, 2024
samster25
reviewed
Aug 13, 2024
samster25
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2617
before
after
I think there's a LOT more we can do to customize the displays for the plans, but this should at least set up the ground work.