Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix projection pushdowns not working with limits #2635

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Vince7778
Copy link
Contributor

Fixes #2616

From Slack:

Essentially the project and the limit are being pushed down in the same rule batch, at the same time. However, this means that if a project and a limit are in the same tree, the project gets pushed down, but then the limit gets immediately pushed down beneath it, resulting in no change, and the project never gets to merge with the scan.

This PR moves limit pushdowns into a different rule batch than projection pushdowns, meaning they no longer conflict with each other.

@github-actions github-actions bot added the bug Something isn't working label Aug 9, 2024
@Vince7778 Vince7778 merged commit 8cf6974 into main Aug 9, 2024
44 checks passed
@Vince7778 Vince7778 deleted the conor/project-pushdown-fix branch August 9, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pushdowns not being applied correctly during optimization
2 participants