Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] (ACTORS-2) Add optimization pass to split Project into ActorPoolProject #2627

Merged
merged 18 commits into from
Aug 23, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Aug 6, 2024

Adds logical optimization for splitting a Project with stateful UDFs into a chain of (Project -> ActorPool -> ActorPool -> ... -> Project)

We then rely on ProjectionPushdown rules to optimize this chain (applying column pruning, projection fusion etc).

@github-actions github-actions bot added the enhancement New feature or request label Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 92.19653% with 27 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@ae13e22). Learn more about missing BASE report.
Report is 4 commits behind head on main.

Files Patch % Lines
...al_optimization/rules/split_actor_pool_projects.rs 93.39% 20 Missing ⚠️
...rc/daft-plan/src/logical_optimization/optimizer.rs 87.50% 5 Missing ⚠️
src/daft-plan/src/logical_optimization/test/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2627   +/-   ##
=======================================
  Coverage        ?   63.56%           
=======================================
  Files           ?      982           
  Lines           ?   112330           
  Branches        ?        0           
=======================================
  Hits            ?    71407           
  Misses          ?    40923           
  Partials        ?        0           
Files Coverage Δ
daft/udf.py 91.98% <ø> (ø)
src/daft-dsl/src/expr.rs 72.36% <100.00%> (ø)
...logical_optimization/rules/push_down_projection.rs 84.17% <ø> (ø)
src/daft-plan/src/logical_optimization/test/mod.rs 83.33% <0.00%> (ø)
...rc/daft-plan/src/logical_optimization/optimizer.rs 90.22% <87.50%> (ø)
...al_optimization/rules/split_actor_pool_projects.rs 93.39% <93.39%> (ø)

@jaychia jaychia force-pushed the jay/stateful-udf-logical-opt branch 2 times, most recently from e2b4c54 to 74447f1 Compare August 9, 2024 20:01
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 9, 2024
@jaychia jaychia force-pushed the jay/stateful-udf-logical-opt branch 3 times, most recently from 37d8728 to 481a0dd Compare August 14, 2024 01:35
@jaychia jaychia force-pushed the jay/stateful-udf-logical-opt branch 2 times, most recently from bf69252 to 2dd4452 Compare August 15, 2024 22:31
@jaychia jaychia changed the base branch from main to jay/allow-setting-actor-pool-size August 15, 2024 22:32
@jaychia jaychia changed the title [FEAT] Add feature-flagged logical optimization pass to split Project into ActorPoolProject [FEAT] Add optimization pass to split Project into ActorPoolProject Aug 15, 2024
@jaychia jaychia force-pushed the jay/stateful-udf-logical-opt branch from 077d92d to 1fb4fb0 Compare August 15, 2024 23:43
@jaychia jaychia changed the title [FEAT] Add optimization pass to split Project into ActorPoolProject [FEAT] (ACTORS-2) Add optimization pass to split Project into ActorPoolProject Aug 16, 2024
Base automatically changed from jay/allow-setting-actor-pool-size to main August 16, 2024 21:10
@jaychia jaychia force-pushed the jay/stateful-udf-logical-opt branch from 772c9a2 to 19dca2d Compare August 19, 2024 14:56
@jaychia jaychia force-pushed the jay/stateful-udf-logical-opt branch from d0bc513 to dc7e648 Compare August 20, 2024 14:34
Copy link

codspeed-hq bot commented Aug 23, 2024

CodSpeed Performance Report

Merging #2627 will not alter performance

Comparing jay/stateful-udf-logical-opt (1fe85eb) with main (ab6d1a5)

Summary

✅ 10 untouched benchmarks

Copy link
Contributor

@desmondcheongzx desmondcheongzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding the test!

@jaychia jaychia merged commit 9df6beb into main Aug 23, 2024
46 checks passed
@jaychia jaychia deleted the jay/stateful-udf-logical-opt branch August 23, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants