Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Dyn Compare + Probe Table #2618

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Aug 5, 2024

  • Enables Dyn Compare + Partial Probe Table creation
    Fn(&dyn Array, &dyn Array, usize, usize) -> Ordering

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 474 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@3b23e16). Learn more about missing BASE report.

Files Patch % Lines
src/daft-table/src/ops/joins/mod.rs 0.00% 124 Missing ⚠️
src/arrow2/src/array/dyn_ord.rs 0.00% 123 Missing ⚠️
src/daft-table/src/probe_table/mod.rs 0.00% 117 Missing ⚠️
src/daft-table/src/growable/mod.rs 0.00% 44 Missing ⚠️
src/daft-core/src/utils/dyn_compare.rs 0.00% 42 Missing ⚠️
src/daft-table/src/lib.rs 0.00% 18 Missing ⚠️
src/daft-core/src/schema.rs 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2618   +/-   ##
=======================================
  Coverage        ?   63.85%           
=======================================
  Files           ?      963           
  Lines           ?   110344           
  Branches        ?        0           
=======================================
  Hits            ?    70455           
  Misses          ?    39889           
  Partials        ?        0           
Files Coverage Δ
src/arrow2/src/array/mod.rs 58.06% <ø> (ø)
src/daft-core/src/utils/mod.rs 86.95% <ø> (ø)
src/daft-core/src/schema.rs 86.08% <0.00%> (ø)
src/daft-table/src/lib.rs 88.21% <0.00%> (ø)
src/daft-core/src/utils/dyn_compare.rs 0.00% <0.00%> (ø)
src/daft-table/src/growable/mod.rs 0.00% <0.00%> (ø)
src/daft-table/src/probe_table/mod.rs 0.00% <0.00%> (ø)
src/arrow2/src/array/dyn_ord.rs 0.00% <0.00%> (ø)
src/daft-table/src/ops/joins/mod.rs 58.85% <0.00%> (ø)

src/arrow2/src/array/dyn_ord.rs Outdated Show resolved Hide resolved
src/daft-table/src/growable/mod.rs Outdated Show resolved Hide resolved
src/daft-table/src/growable/mod.rs Outdated Show resolved Hide resolved
src/daft-table/src/ops/joins/mod.rs Show resolved Hide resolved
src/daft-table/src/probe_table/mod.rs Outdated Show resolved Hide resolved
@samster25 samster25 enabled auto-merge (squash) August 5, 2024 22:31
@samster25 samster25 merged commit 230feb3 into main Aug 5, 2024
44 checks passed
@samster25 samster25 deleted the sammy/dyn-compare-probe-table branch August 5, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants