[FEAT] Add hashjoin, sort, and hashagg ops to new executor #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
=======================================
Coverage ? 63.08%
=======================================
Files ? 975
Lines ? 108599
Branches ? 0
=======================================
Hits ? 68512
Misses ? 40087
Partials ? 0
|
samster25
reviewed
Jul 18, 2024
| } | ||
|
|
||
| fn name(&self) -> &'static str { | ||
| "Concat" |
| } | ||
|
|
||
| fn in_order(&self) -> bool { | ||
| true |
There was a problem hiding this comment.
hash join shouldn't care about order?
| } | ||
|
|
||
| fn in_order(&self) -> bool { | ||
| true |
There was a problem hiding this comment.
sort should also not care about order, since it makes it own
samster25
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TPCH 1-10 is good to go