[BUG] Use shared thread pool for multiple running instances of df on pyrunner #2502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thread_pool
from a local per-generator variable to a sharedself._thread_pool
in the singleton runnerinflight_tasks_resources
andinflight_tasks
to shared variables in the singleton runnerThe second part of this is a little dangerous because of the way these variables are used that can introduce a potential race condition:
self._can_admit_task
checks against theinflight_tasks_resources
to see if a task can be admittedinflight_tasks_resources
If another iterator is somehow able to update
inflight_tasks_resources
between steps 1 and 2, then our resource accounting would fail. However, I think this should never happen because our generators are not pre-emptable, and I don't think this race condition is possible.