Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Support delta-rs version >0.17.4 in deltalake writes #2488

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jul 8, 2024

Daft had some bad code when handling newer versions of delta-rs

@github-actions github-actions bot added the bug Something isn't working label Jul 8, 2024
@jaychia jaychia requested a review from kevinzwang July 8, 2024 21:39
@jaychia jaychia changed the title [BUG] Support delta-rs version <0.17.4 in deltalake writes [BUG] Support delta-rs version >0.17.4 in deltalake writes Jul 8, 2024
@jaychia
Copy link
Contributor Author

jaychia commented Jul 8, 2024

Actually, I'll update our requirements-dev.txt to use a new version of deltalake and verify that the fix is good in CI

@jaychia jaychia force-pushed the jay/support-delta-rs-lt-0.17.4 branch from a5bb045 to f1550d3 Compare July 8, 2024 21:59
Copy link
Contributor

@desmondcheongzx desmondcheongzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, confirmed that it works locally

@jaychia jaychia merged commit 83532e2 into main Jul 8, 2024
42 checks passed
@jaychia jaychia deleted the jay/support-delta-rs-lt-0.17.4 branch July 8, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants