[BUG] Fix anti-join on different column names

[Vince7778]

Closes #2475.

A bit of a bandaid fix. The issue was, while selecting the join strategy, for checking whether sort-merge join works, the joined columns need to be primitive types. However, in the plan we only have access to the output schema (as far as I know, maybe we can extract it from the children?). In a semi- or anti-join, the right column does not end up in the output schema, so the primitive type check panicked while looking for it. This issue does not appear if the left column has the same name as the right.

My fix is that, since we only support SMJ for inner joins, I move the join type check before the primitive check. This will need to be fixed later if we support SMJ for anti-joins, so I added a comment.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@674e500). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2477   +/-   ##
=======================================
  Coverage        ?   63.41%           
=======================================
  Files           ?      947           
  Lines           ?   106304           
  Branches        ?        0           
=======================================
  Hits            ?    67409           
  Misses          ?    38895           
  Partials        ?        0           

Files	Coverage Δ
src/daft-plan/src/physical_planner/translate.rs	90.90% <100.00%> (ø)

[samster25]

Thanks for the fix!