Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Optimize string normalization #2474

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Conversation

Vince7778
Copy link
Contributor

Slight optimization of string normalization. Speeds up that step around 2x (mostly by removing regex)

@Vince7778 Vince7778 changed the title Optimize string normalization [PERF] Optimize string normalization Jul 3, 2024
Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice easy win

src/daft-core/src/array/ops/utf8.rs Show resolved Hide resolved
@Vince7778 Vince7778 merged commit e5ff7d7 into main Jul 8, 2024
43 checks passed
@Vince7778 Vince7778 deleted the conor/str-normalize-optimize branch July 8, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants