Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] String normalize expression #2450

Merged
merged 2 commits into from
Jun 29, 2024
Merged

[FEAT] String normalize expression #2450

merged 2 commits into from
Jun 29, 2024

Conversation

Vince7778
Copy link
Contributor

Adds an expression to normalize strings, for preprocessing for deduplication. Offers four options: removing punctuation, lowercasing, removing extra whitespace, and Unicode normalization.

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 29, 2024
Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small comments but nothing blocking a merge

src/daft-core/src/array/ops/utf8.rs Outdated Show resolved Hide resolved
src/daft-core/src/array/ops/utf8.rs Show resolved Hide resolved
src/daft-core/src/array/ops/utf8.rs Outdated Show resolved Hide resolved
@Vince7778 Vince7778 enabled auto-merge (squash) June 29, 2024 00:45
@Vince7778 Vince7778 merged commit 29b02a1 into main Jun 29, 2024
43 checks passed
@Vince7778 Vince7778 deleted the conor/string-normalize branch June 29, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants