[FEAT] New Local Execution Model #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-ho
commented
Jun 26, 2024
tests/integration/test_tpch.py
Outdated
Comment on lines
78
to
84
| def test_tpch_q6(tmp_path, check_answer, get_df): | ||
| daft.context.set_execution_config(enable_aqe=True, enable_native_executor=True) | ||
| start = time.time() | ||
| daft_df = answers.q6(get_df) | ||
| daft_pd_df = daft_df.to_pandas() | ||
| end = time.time() | ||
| print(f"Time taken: {end-start}") |
There was a problem hiding this comment.
Currently the runtime is the same for current engine vs the simple local execution engine in this PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2437 +/- ##
==========================================
+ Coverage 63.12% 63.31% +0.19%
==========================================
Files 938 961 +23
Lines 105269 107395 +2126
==========================================
+ Hits 66449 68002 +1553
- Misses 38820 39393 +573
|
colin-ho
commented
Jul 8, 2024
|
|
||
| let mut handles = FuturesUnordered::new(); | ||
| let mut receivers = vec![]; | ||
| while let Some(morsel) = source_stream.next().await { |
There was a problem hiding this comment.
There should be a fixed number of parallel pipelines that are pushed data to in round robin fashion
|
follow on PRs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype for new local execution model