Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add better typing for class UDFs #2388

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[CHORE] Add better typing for class UDFs #2388

merged 1 commit into from
Jul 8, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jun 17, 2024

Updates the typing for class UDF to allow for both function UDFs and stateful class UDFs

@github-actions github-actions bot added the chore label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@395ebe8). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2388   +/-   ##
=======================================
  Coverage        ?   63.50%           
=======================================
  Files           ?      910           
  Lines           ?   102108           
  Branches        ?        0           
=======================================
  Hits            ?    64839           
  Misses          ?    37269           
  Partials        ?        0           
Files Coverage Δ
daft/udf.py 92.85% <100.00%> (ø)

@jaychia jaychia enabled auto-merge (squash) July 7, 2024 23:20
@jaychia jaychia merged commit f142166 into main Jul 8, 2024
43 checks passed
@jaychia jaychia deleted the jay/UDF-typing branch July 8, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant