Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] the project currently uses ray which is not compatible with python 3.12 #2354

Merged

Conversation

prabodh1194
Copy link
Contributor

@prabodh1194 prabodh1194 commented Jun 9, 2024

I was setting up daft dev environment on my local and was following along the contribution guidelines. my default python env is currently at 3.12 and noticed that the make .venv keeps failing due to dependency on ray[data]==2.10.0. the failure happens because the current ray-data is only compatible till python3.11.

@prabodh1194 prabodh1194 changed the title the project currently uses ray which is not compatible with python 3.12 [DOCS] the project currently uses ray which is not compatible with python 3.12 Jun 9, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 9, 2024
@prabodh1194
Copy link
Contributor Author

At my company's codebase, we generally use specific python versions, say python3.11 in the Makefile so that multiple python version can be easily accommodated. If it is fine, I can even update the Makefile with relevant changes as well.

@samster25
Copy link
Member

Hi @prabodh1194! Thanks for making this docs update!

If you have some ideas on how use a specific version of python across people machines, that would be a welcome contribution!

@samster25 samster25 merged commit dd20c12 into Eventual-Inc:main Jun 10, 2024
42 of 44 checks passed
@prabodh1194 prabodh1194 deleted the update_contribution_guidelines branch June 10, 2024 08:04
@prabodh1194
Copy link
Contributor Author

For sure. I'll raise a pr for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants